Various updates =) #80
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If a builder image has an entrypoint (say via inheritance from it's base builder image) then in order for the snowdrop buildpack lib to function correctly, we must wipe the entrypoint when setting the command, else we'll invoke the wrong thing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated logging to be more concise with use of info, moved verbose output to debug.
Updated DockerConfig to have correct names for getters, was breaking sundrio usage & preventing docker timeout being configurable.
Clears entrypoint when invoking containers for phases, to prevent existing entrypoints from causing bad behavior.