Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade to Camel 4.0.0-RC1, add bugfix to CamelServiceShutdownControllerAutoConfiguration and add integration test for un/successful round trip in recovery controller #102

Merged
merged 1 commit into from
Jul 24, 2023
Merged

Upgrade to Camel 4.0.0-RC1, add bugfix to CamelServiceShutdownControllerAutoConfiguration and add integration test for un/successful round trip in recovery controller #102

merged 1 commit into from
Jul 24, 2023

Conversation

graben
Copy link
Contributor

@graben graben commented Jul 9, 2023 •
edited
Loading

  • Update Camel 4 from M3 to RC1
  • Fix bug in CamelServiceShutdownControllerAutoConfiguration
  • Extract DefaultOpenShiftClient creation to AutoConfiguration to make testable
  • Add successful and unsuccessful roundtrip integration tests to verify bean creation and interaction with Kubernetes API

Hi @Sgitario, could plz review this fix.
Thx Benjamin

@graben graben force-pushed the camel4 branch 7 times, most recently from 1d24f10 to e3a76cd Compare July 11, 2023 17:47
@graben graben changed the title Upgrade to Camel 4.0.0-RC1, add fix to CamelServiceShutdownController and add integration test for complete kubernetes roundtrip in recovery controller Upgrade to Camel 4.0.0-RC1, add bugfix to CamelServiceShutdownControllerAutoConfiguration and add integration test for successful round trip in recovery controller Jul 11, 2023
@graben
Upgrade to Camel 4.0.0-RC1, add bugfix to CamelServiceShutdownControl…
f747191 
…lerAutoConfiguration and add integration test for un/successful round trip in recovery controller
@graben graben changed the title Upgrade to Camel 4.0.0-RC1, add bugfix to CamelServiceShutdownControllerAutoConfiguration and add integration test for successful round trip in recovery controller Upgrade to Camel 4.0.0-RC1, add bugfix to CamelServiceShutdownControllerAutoConfiguration and add integration test for un/successful round trip in recovery controller Jul 11, 2023
Sgitario
Sgitario approved these changes Jul 24, 2023
View reviewed changes
Copy link
Contributor

@Sgitario Sgitario left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! thanks!

@Sgitario Sgitario merged commit 2bcca1e into snowdrop:main Jul 24, 2023
1 check passed
@graben graben deleted the camel4 branch July 24, 2023 05:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sgitario Sgitario Sgitario approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@graben @Sgitario