Generate right-length nodeIdentifier/ XID #136
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generate right-length nodeIdentifier if nodeIdentifier is longer than 28 bytes, the XID generated by narayana ist too long, and it breaks. This shortens it, while nodeIdentifier remains unique. Fix ported from quarkus quarkusio/quarkus#30491
geoand
approved these changes
Mar 5, 2024
|
@geoand: Is there still something missing, preventing merge? |
|
What's make you say that? |
|
@geoand : Would it be possible to trigger someone, e.g. @jacobdotcosta to do a 3.0.1 release soon? Thanks, Benjamin |
|
As you said, up to @jacobdotcosta :) |
graben
added a commit
to graben/narayana-spring-boot
that referenced
this pull request
Apr 24, 2024
cunningt
pushed a commit
to cunningt/narayana-spring-boot
that referenced
this pull request
Jun 24, 2024
cunningt
added a commit
to jboss-fuse/narayana-spring-boot
that referenced
this pull request
Jun 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolve #132
@geoand: This one is squashed and rebased ;)