Adapt to SpringBoot 3, Camel 4 and Jakarta EE, removing DBCP feature and deprecated methods

[graben]

Major upgrade to latest Spring-Boot, Narayana and several other dependencies, replacing incompatible DBCP feature with Agroal.

Resolves #95
Resolves #97
Depends: agroal/agroal#63, agroal/agroal#65, agroal/agroal#66, agroal/agroal#67, agroal/agroal#68

[zhfeng]

Thanks @graben and how io.agroal:agroal-spring-boot-starter can work with narayana ? I didn't see any test with agroal-spring-boot.

[graben]

Hi @zhfeng, io.agroal:agroal-spring-boot-starter comes with Narayana integration out of the box, nothing to do. I'll add tests once a few bugs are solved at agroal.

[zhfeng]

OK - if that is the case, I think we should disable XADataSourceWrapper when using io.agroal:agroal-spring-boot-starter. agroal could take care all of the transaction integration.

Please make sure the transaction crash recovery is still working when you are adding test with agroal.

[graben]

Well, XADataSourceWrapper is still useful for non pooled DataSources which are not handled by agroal. Pooling has been completely removed from sourcecode, yet. The code at agroal has been developed by some Narayana guys from RedHat, I think they know what they are doing. ;-)

[zhfeng]

When using with agroal-spring-boot, XADataSourceWrapper will still wrap the DatsSource creaing by agroal-spring-boot?

[zhfeng]

@graben Can I ask for taking the removing dbcp in a seperate commit ? Since there is a discussion to support jakarta in dbcp, so it could be easy to bring dbcp back in the future.

Thanks a lot!

[graben]

@zhfeng , I can restore DBCP support at any time. IMHO the discussion at commons is never ending, that's why I took the step forward for an alternative way. Btw agroal is creating a DataSource instance, so no problem with rewrapping by XADataSourceWrapper and they use narayana-spring-boot for their tests.

[zhfeng]

@graben - I see.

For rewrapping, the only thing I concern is about registering the XAResourceRecoveryHelper. It seems that if we don't disable XADataSourceWrapper, there could be two XAResourceRecoveryHelper (one from agroal, and the other from GenericXADataSourceWrapper then during crash recovering, the recovery manager could confuse the same Xids from the different XAResourceRecovery. That might be a potenial issue.

[graben]

Since no XADataSource instance is created, there is no problem with the GenericXADataSourceWrapper. Only one XAResourceRecoveryHelper is registered. But I can double-check with debugger in my personnel prototype app.

[zhfeng]

Hmm, agroal will only create DataSource but not XADataSource? It should be OK. Anyway, thank for double-checking. I might be too worries.

[graben]

Hi @zhfeng, I split the commit into two parts as requested.

[zhfeng]

Thanks @graben - LGTM!

[graben]

@zhfeng: Changes good to be merged? It seems that your Fuse colleges at RedHat are fine with the changes proposed!

[zhfeng]

Thanks @graben - It looks good to me!

[graben]

@jacobdotcosta : Could you pls review and merge?

[jacobdotcosta]

I don't think I'm the right person to review this PR, could you take a look at it @Sgitario , please?

[Sgitario]

I don't think I'm the right person to review this PR, could you take a look at it @Sgitario , please?

I have never worked in this repository either @jacobdotcosta

[geoand]

It looks fine from a strictly Spring Boot perspective

[graben]

@geoand : Would you like to approve and merge? The number of repository owners is quite small! Same for my other PRs.

[johnpoth]

Is there a release planned soon containing these changes ? Thanks !

[geoand]

@jacobdotcosta ^