Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SNOW-1256899 Enable structured types on GH tests #1130

Merged
merged 2 commits into from
Jun 27, 2024

Conversation

sfc-gh-pfus
Copy link
Collaborator

Description

SNOW-1256899 Enable structured types tests on github.

Checklist

  • Created tests which fail without the change (if possible)
  • Extended the README / documentation, if necessary

Copy link

codecov bot commented May 14, 2024

Codecov Report

Attention: Patch coverage is 88.46154% with 6 lines in your changes missing coverage. Please review.

Project coverage is 83.16%. Comparing base (7ec87ef) to head (e352c90).
Report is 1 commits behind head on master.

Files Patch % Lines
converter.go 86.95% 6 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           master    #1130       +/-   ##
===========================================
+ Coverage   71.63%   83.16%   +11.53%     
===========================================
  Files          54       54               
  Lines       12117    12149       +32     
===========================================
+ Hits         8680    10104     +1424     
+ Misses       3437     2045     -1392     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sfc-gh-pfus sfc-gh-pfus force-pushed the SNOW-1256899-enable-structured-types-tests-on-gh branch 4 times, most recently from 4a95a73 to d546a22 Compare May 22, 2024 09:39
@sfc-gh-pfus sfc-gh-pfus force-pushed the SNOW-1256899-enable-structured-types-tests-on-gh branch 3 times, most recently from f17abfc to 929e737 Compare June 5, 2024 08:30
@sfc-gh-pfus sfc-gh-pfus force-pushed the SNOW-1256899-enable-structured-types-tests-on-gh branch 4 times, most recently from 597b7dd to da066e1 Compare June 17, 2024 07:41
@sfc-gh-pfus sfc-gh-pfus force-pushed the SNOW-1256899-enable-structured-types-tests-on-gh branch 18 times, most recently from c5d17ee to 90f941e Compare June 26, 2024 06:29
@sfc-gh-pfus sfc-gh-pfus force-pushed the SNOW-1256899-enable-structured-types-tests-on-gh branch 5 times, most recently from b0ed851 to 2ee1d02 Compare June 27, 2024 06:33
@sfc-gh-pfus sfc-gh-pfus force-pushed the SNOW-1256899-enable-structured-types-tests-on-gh branch from 2ee1d02 to 739731e Compare June 27, 2024 07:30
@sfc-gh-pfus sfc-gh-pfus marked this pull request as ready for review June 27, 2024 08:16
@sfc-gh-pfus sfc-gh-pfus requested a review from a team as a code owner June 27, 2024 08:16
@sfc-gh-pfus sfc-gh-pfus merged commit 52590b9 into master Jun 27, 2024
36 checks passed
@sfc-gh-pfus sfc-gh-pfus deleted the SNOW-1256899-enable-structured-types-tests-on-gh branch June 27, 2024 12:30
@github-actions github-actions bot locked and limited conversation to collaborators Jun 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants