-
Notifications
You must be signed in to change notification settings - Fork 116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SNOW-1346547: add check for session expiry when getting query result #1160
Merged
+130
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1160 +/- ##
==========================================
+ Coverage 71.60% 71.63% +0.03%
==========================================
Files 54 54
Lines 12092 12117 +25
==========================================
+ Hits 8658 8680 +22
- Misses 3434 3437 +3 ☔ View full report in Codecov by Sentry. |
sfc-gh-pfus
reviewed
Jun 19, 2024
6bc7857
to
73c4f8c
Compare
…owflakedb/gosnowflake into 957-session-expire-after-1-hr
sfc-gh-pfus
approved these changes
Jun 26, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
drivers issue 957: https://github.com/snowflakedb/snowflake-sdks-drivers-issues-teamwork/issues/957
The root cause is that the heartbeat process has renewed the session token here but the new token in the get query result request's header was not updated in getQueryResultWithRetriesForAsyncMode().
This PR adds a check for session expiry in
getQueryResultWithRetriesForAsyncMode()
and update the token in the header if needed. Similar to ODBC's implementation here, where there should be a check for the session expired code 390112 during the getting query result request and allows a retry after updating the session token.Checklist