Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ocsp test failing on timeout #1169

Merged
merged 1 commit into from
Jun 27, 2024
Merged

Fix ocsp test failing on timeout #1169

merged 1 commit into from
Jun 27, 2024
+2 −1

Conversation

sfc-gh-pfus
Copy link
Collaborator

@sfc-gh-pfus sfc-gh-pfus commented Jun 27, 2024 •
edited
Loading

Description

badssl.com times out every now and then. We don't want to fail our builds because external service is timing out.

Checklist

  • Created tests which fail without the change (if possible)
  • Extended the README / documentation, if necessary

@sfc-gh-pfus sfc-gh-pfus marked this pull request as ready for review June 27, 2024 08:47
@sfc-gh-pfus sfc-gh-pfus requested a review from a team as a code owner June 27, 2024 08:47
@sfc-gh-pfus sfc-gh-pfus merged commit c126b2a into master Jun 27, 2024
32 of 34 checks passed
@sfc-gh-pfus sfc-gh-pfus deleted the ocsp.timeout branch June 27, 2024 08:51
@github-actions github-actions bot locked and limited conversation to collaborators Jun 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sfc-gh-dheyman-1 sfc-gh-dheyman-1 sfc-gh-dheyman-1 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@sfc-gh-pfus @sfc-gh-dheyman-1