Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SNOW-1416000 Structure types array null handling #1179

Merged

Conversation

sfc-gh-astachowski
Copy link
Contributor

Description

SNOW-1416000 Added new context option that makes values within arrays be parsed to sql.NullXYZ types, allowing for handling nulls in the data.

Checklist

  • Created tests which fail without the change (if possible)
  • Extended the README / documentation, if necessary

@sfc-gh-astachowski sfc-gh-astachowski marked this pull request as ready for review July 17, 2024 08:09
@sfc-gh-astachowski sfc-gh-astachowski requested a review from a team as a code owner July 17, 2024 08:09
converter.go Show resolved Hide resolved
converter.go Show resolved Hide resolved
converter.go Outdated Show resolved Hide resolved
converter.go Outdated Show resolved Hide resolved
converter.go Outdated Show resolved Hide resolved
converter.go Show resolved Hide resolved
converter.go Show resolved Hide resolved
structured_type.go Show resolved Hide resolved
Copy link

codecov bot commented Jul 17, 2024

Codecov Report

Attention: Patch coverage is 53.47826% with 107 lines in your changes missing coverage. Please review.

Project coverage is 82.59%. Comparing base (cecf890) to head (c521e6a).
Report is 1 commits behind head on master.

Files Patch % Lines
converter.go 54.02% 97 Missing ⚠️
errors.go 0.00% 10 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1179      +/-   ##
==========================================
- Coverage   83.01%   82.59%   -0.43%     
==========================================
  Files          54       54              
  Lines       12658    12815     +157     
==========================================
+ Hits        10508    10584      +76     
- Misses       2150     2231      +81     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Jul 18, 2024

All contributors have signed the CLA ✍️ ✅
Posted by the CLA Assistant Lite bot.

@sfc-gh-astachowski
Copy link
Contributor Author

I have read the CLA Document and I hereby sign the CLA

@sfc-gh-astachowski sfc-gh-astachowski merged commit 7cb9406 into master Jul 25, 2024
36 of 38 checks passed
@sfc-gh-astachowski sfc-gh-astachowski deleted the SNOW-1416000-handle-nulls-in-structured-types-arrays branch July 25, 2024 13:45
@github-actions github-actions bot locked and limited conversation to collaborators Jul 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants