Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SNOW-1540431 Init ocsp local cache even if cache server is disabled #1181

Merged
merged 2 commits into from
Jul 17, 2024

Conversation

sfc-gh-pfus
Copy link
Collaborator

Description

SNOW-1540431 Before this change local cache was not initialized when cache server was disabled, even though we still used it. Cannot reproduce in automatic tests, as driver is initialized once for all tests.

Checklist

  • Created tests which fail without the change (if possible)
  • Extended the README / documentation, if necessary

@sfc-gh-pfus sfc-gh-pfus marked this pull request as ready for review July 17, 2024 07:07
@sfc-gh-pfus sfc-gh-pfus requested a review from a team as a code owner July 17, 2024 07:07
Copy link

codecov bot commented Jul 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.02%. Comparing base (9730225) to head (e508f66).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1181      +/-   ##
==========================================
- Coverage   83.02%   83.02%   -0.01%     
==========================================
  Files          54       54              
  Lines       12653    12652       -1     
==========================================
- Hits        10505    10504       -1     
  Misses       2148     2148              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sfc-gh-pfus sfc-gh-pfus merged commit cecf890 into master Jul 17, 2024
33 of 34 checks passed
@sfc-gh-pfus sfc-gh-pfus deleted the SNOW-1540431-ocsp-init branch July 17, 2024 11:32
@github-actions github-actions bot locked and limited conversation to collaborators Jul 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants