SNOW-1552759 Remove attempt to detect DBUS_SESSION_BUS_ADDRESS and emitting warning message (revert #1058 except the doc changes)
#1184
+0
−39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Short term 'fix' to avoid unnecessary messages due to some apparent false positives * Long term fix on separate ticket
sfc-gh-pfus
approved these changes
Jul 24, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1184 +/- ##
==========================================
+ Coverage 83.01% 83.11% +0.09%
==========================================
Files 54 54
Lines 12658 12629 -29
==========================================
- Hits 10508 10496 -12
+ Misses 2150 2133 -17 ☔ View full report in Codecov by Sentry. |
sfc-gh-dheyman-1
approved these changes
Jul 25, 2024
sfc-gh-dszmolka
changed the title
DBUS_SESSION_BUS_ADDRESS and emitting warning message (revert #1058 except the doc changes)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apparently in some cases, this caused false positives (e.g. when
sudowasn't called in a way to carry over envvars from the calling user,DBUS_SESSION_BUS_ADDRESSwasn't carried over and resulted in a false positive + warning)Revert #1058 except the doc changes