SNOW-209092 Skip Session Close

[sfc-gh-jbahk]

Description

Added a control flow to keep client session alive if parameter enabled.

Checklist

• Code compiles correctly
• Run make fmt to fix inconsistent formats
• Run make lint to get lint errors and fix all of them
• Created tests which fail without the change (if possible)
• All tests passing
• Extended the README / documentation, if necessary

[sfc-gh-anezvigin]

My concern with using isClientSessionKeepAliveEnabled() is that if you turn on keep-alive, there's no way to close the session even if you wanted to.

[sfc-gh-anezvigin]

Also this is a pretty big behavior change for existing users of the driver that are turning off keep alive. Their sessions will stay open on the GS side.

[sfc-gh-jbahk]

I was thinking that users already enable the client_session_keep_alive to have the session persist and turn it off, followed by Close() to properly close the session. What do you think?

[sfc-gh-cshi]

Seems we don't have end to end test for this session persistence change for go driver. Should we have one?

[sfc-gh-anezvigin]

I was thinking that users already enable the client_session_keep_alive to have the session persist and turn it off, followed by Close() to properly close the session. What do you think?

Problem is that Close() does more than just optionally close the snowflake session. Go's SQL interface uses it to clean up resources (eg: open channels, etc) that it uses to manage the query lifecycle. The user must call Close() when using the driver in long running processes.

So the following scenario would create a resource leak:

• Long running process (eg: API server)
• Sets client_session_keep_alive to false
• Does not call Close() on the sql.DB object

[sfc-gh-anezvigin]

👍

[sfc-gh-dwu]

context.Todo() or should this be sc.ctx

[sfc-gh-dwu]

lgtm with 1 ctx change