-
Notifications
You must be signed in to change notification settings - Fork 126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SNOW-723750: Panic with readonly file system #828
SNOW-723750: Panic with readonly file system #828
Conversation
Thank you for starting this work! Will it be possible to disable the temp file creation mechanism completely for certain workflows? It's not fully clear to me when it's beneficial, especially when the data is streamed from/to a buffer or a file. Also, when one wishes to run a quick @sfc-gh-dszmolka mentioned in this comment that encryption/decription also creates temp files. Will this PR also address that workflow? Also, it might be worth considering a Snowflake-specific name for the env var which controls the location of this temporary directory, maybe something like |
Removing the usage of the temp folder is not planned.
The encryption/decryption workflow was not affected with this bug - the creation of the temp file itself does not panic but returns the error which was not properly handled. The driver wanted to assign the error to the
That is a very good idea - we have prepared a feature request to expand the driver with such functionality. |
bcae783
to
65e5b57
Compare
ae5f8ec
to
2dfbeb7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
8ea4fb3
to
35746df
Compare
Description
Fixed driver panicking when the temp filesystem is readonly.
Checklist
make fmt
to fix inconsistent formatsmake lint
to get lint errors and fix all of them