Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SNOW-845733 - Add Jenkins user to allow list for CLA Assistant check #830

Merged
merged 3 commits into from
Jun 23, 2023
Merged

SNOW-845733 - Add Jenkins user to allow list for CLA Assistant check #830

merged 3 commits into from
Jun 23, 2023

Conversation

sfc-gh-anavalos
Copy link
Contributor

Description

CLA Assistant check has been failing for release branches. The failure is due the jenkins user used to create the branch and do the commit is not in the allowed list in that check.
The fix is to add it.

Checklist

  • Code compiles correctly
  • Run make fmt to fix inconsistent formats
  • Run make lint to get lint errors and fix all of them
  • Created tests which fail without the change (if possible)
  • All tests passing
  • Extended the README / documentation, if necessary

@sfc-gh-anavalos sfc-gh-anavalos requested a review from a team as a code owner June 21, 2023 20:45
sfc-gh-igarish
sfc-gh-igarish approved these changes Jun 22, 2023
View reviewed changes
Copy link
Collaborator

@sfc-gh-igarish sfc-gh-igarish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sfc-gh-anavalos sfc-gh-anavalos merged commit 663cccc into master Jun 23, 2023
@sfc-gh-anavalos sfc-gh-anavalos deleted the add-jenkinsuser-cla branch June 23, 2023 17:40
@github-actions github-actions bot locked and limited conversation to collaborators Jun 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sfc-gh-igarish sfc-gh-igarish sfc-gh-igarish approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sfc-gh-anavalos @sfc-gh-igarish