Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

addedd support for sql.Null types #833

Closed
wants to merge 2 commits into from

Conversation

m-pavel
Copy link

@m-pavel m-pavel commented Jun 23, 2023

Description

Bypass nil value types to the API call so the server can call procedure/function properly.
Fixes #831

Checklist

  • Code compiles correctly
  • Run make fmt to fix inconsistent formats
  • Run make lint to get lint errors and fix all of them
  • Created tests which fail without the change (if possible)
  • All tests passing
  • Extended the README / documentation, if necessary

@m-pavel m-pavel requested a review from a team as a code owner June 23, 2023 12:03
@github-actions
Copy link

github-actions bot commented Jun 23, 2023

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@m-pavel
Copy link
Author

m-pavel commented Jun 23, 2023

I have read the CLA Document and I hereby sign the CLA

@sfc-gh-dszmolka
Copy link
Contributor

thank you @m-pavel for your contribution here ! in the end we ended up going with a different solution which has been implemented with #844 and released as part of driver version 1.6.23. since it's implemented, marking this PR as closed for now.

@github-actions github-actions bot locked and limited conversation to collaborators Jul 31, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Passing null values to the function call
2 participants