-
Notifications
You must be signed in to change notification settings - Fork 126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SNOW-852381: [gosnowflake] Add documentation for external browser timeout #837
Merged
sfc-gh-pbulawa
merged 5 commits into
master
from
504-snow-852381-gosnowflake-add-documentation-for-external-browser-timeout
Jul 4, 2023
Merged
SNOW-852381: [gosnowflake] Add documentation for external browser timeout #837
sfc-gh-pbulawa
merged 5 commits into
master
from
504-snow-852381-gosnowflake-add-documentation-for-external-browser-timeout
Jul 4, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sfc-gh-pbulawa
requested review from
sfc-gh-dszmolka,
sfc-gh-igarish,
sfc-gh-dheyman-1 and
sfc-gh-pfus
June 29, 2023 08:11
sfc-gh-pfus
reviewed
Jun 29, 2023
sfc-gh-pfus
reviewed
Jun 29, 2023
sfc-gh-pfus
approved these changes
Jun 29, 2023
sfc-gh-pfus
approved these changes
Jun 29, 2023
sfc-gh-igarish
approved these changes
Jul 3, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
sfc-gh-pbulawa
deleted the
504-snow-852381-gosnowflake-add-documentation-for-external-browser-timeout
branch
July 4, 2023 06:27
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added the documentation for external browser authentication timeout and added the possibility to configure the parameter through DSN.
Checklist
make fmt
to fix inconsistent formatsmake lint
to get lint errors and fix all of them