Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SNOW-852381: [gosnowflake] Add documentation for external browser timeout #837

Conversation

sfc-gh-pbulawa
Copy link
Collaborator

@sfc-gh-pbulawa sfc-gh-pbulawa commented Jun 29, 2023

Description

Added the documentation for external browser authentication timeout and added the possibility to configure the parameter through DSN.

Checklist

  • Code compiles correctly
  • Run make fmt to fix inconsistent formats
  • Run make lint to get lint errors and fix all of them
  • Created tests which fail without the change (if possible)
  • All tests passing
  • Extended the README / documentation, if necessary

doc.go Outdated Show resolved Hide resolved
doc.go Outdated Show resolved Hide resolved
doc.go Outdated Show resolved Hide resolved
doc.go Outdated Show resolved Hide resolved
doc.go Outdated Show resolved Hide resolved
connection.go Outdated Show resolved Hide resolved
Copy link
Collaborator

@sfc-gh-igarish sfc-gh-igarish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sfc-gh-pbulawa sfc-gh-pbulawa merged commit 4bf2ccb into master Jul 4, 2023
@sfc-gh-pbulawa sfc-gh-pbulawa deleted the 504-snow-852381-gosnowflake-add-documentation-for-external-browser-timeout branch July 4, 2023 06:27
@github-actions github-actions bot locked and limited conversation to collaborators Jul 4, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants