Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SNOW-859548 Reuse connection in tests #856

Merged
merged 1 commit into from
Jul 21, 2023
Merged

SNOW-859548 Reuse connection in tests #856

merged 1 commit into from
Jul 21, 2023

Conversation

sfc-gh-pfus
Copy link
Collaborator

@sfc-gh-pfus sfc-gh-pfus commented Jul 19, 2023 •
edited
Loading

Description

All tests opened new connections, even if they could reuse a connection from the pool. Migrating to the pool decreased tests time around 15%.

Checklist

  • Code compiles correctly
  • Run make fmt to fix inconsistent formats
  • Run make lint to get lint errors and fix all of them
  • Created tests which fail without the change (if possible)
  • All tests passing
  • Extended the README / documentation, if necessary

@sfc-gh-pfus sfc-gh-pfus force-pushed the SNOW-859548-reuse-conn-in-test branch 8 times, most recently from 66931cd to d39a66c Compare July 19, 2023 13:16
@sfc-gh-pfus sfc-gh-pfus marked this pull request as ready for review July 20, 2023 06:01
@sfc-gh-pfus sfc-gh-pfus requested a review from a team as a code owner July 20, 2023 06:01
sfc-gh-pbulawa
sfc-gh-pbulawa reviewed Jul 20, 2023
View reviewed changes
async_test.go Show resolved Hide resolved
arrow_test.go Show resolved Hide resolved
@sfc-gh-pfus sfc-gh-pfus force-pushed the SNOW-859548-reuse-conn-in-test branch from d39a66c to 41e2b6e Compare July 20, 2023 06:57
@sfc-gh-igarish
Copy link
Collaborator

make sure one test failure won't affect run of other tests. e.g. first test getting connection failed, other tests should try to get the connection and run as independent test.

sfc-gh-igarish
sfc-gh-igarish approved these changes Jul 20, 2023
View reviewed changes
Copy link
Collaborator

@sfc-gh-igarish sfc-gh-igarish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sfc-gh-pfus sfc-gh-pfus merged commit c61ffc0 into master Jul 21, 2023
@sfc-gh-pfus sfc-gh-pfus deleted the SNOW-859548-reuse-conn-in-test branch July 21, 2023 05:39
@github-actions github-actions bot locked and limited conversation to collaborators Jul 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sfc-gh-pbulawa sfc-gh-pbulawa sfc-gh-pbulawa approved these changes

@sfc-gh-igarish sfc-gh-igarish sfc-gh-igarish approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sfc-gh-pfus @sfc-gh-igarish @sfc-gh-pbulawa