Proof-of-concept for "snow ws" command generation #1540
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| return | ||
|
|
||
| root = dm.unrendered_project_definition | ||
| for (target_id, model) in root.entities.items(): |
There was a problem hiding this comment.
Should we consider model.get_command_group(target_id) that would encapsulate L100-102? WDYT?
There was a problem hiding this comment.
I'm not sure I quite understand the suggestion. Can you give a bit more detail?
sfc-gh-cgorrie
force-pushed
the
cgorrie-uber-command
branch
from
e8bc42d
to
5c2d51a
Compare
sfc-gh-cgorrie
force-pushed
the
cgorrie-uber-command
branch
from
5c2d51a
to
487ff20
Compare
sfc-gh-cgorrie
force-pushed
the
cgorrie-uber-command
branch
from
487ff20
to
16a4f7b
Compare
| pass_through_options = { | ||
| k: v for (k, v) in options.items() if k in known_params | ||
| } | ||
| ws.perform_action(self.target_id, action, **pass_through_options) |
There was a problem hiding this comment.
how do we handle return values? for example, we currently have some command that wrap the return value of the entity action in MessageResult, others use QueryResult, etc
Comment on lines
+142
to
+144
| return MessageResult( | ||
| f"Successfully performed {action.verb} on {self.target_id}." | ||
| ) |
There was a problem hiding this comment.
not all actions want to show a success message (especially those that retrieve data, like version-list)
|
Closing this for now due to uncertainty regarding the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pre-review checklist
Changes description
Generates
snow ws @<entity_id>command groups based on the current directory'ssnowflake.yml.What's done:
HelpText,ParameterDeclarations) that ensures individual commands don't actually rely on click / typerThings that need addressing:
snow @pkg version create v1needs to be passed in instead as--version v1)