-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Factories for test data #1592
Merged
Merged
Factories for test data #1592
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…/snowflake-cli into pj-test-fb-test-data
sfc-gh-fcampbell
previously approved these changes
Sep 25, 2024
sfc-gh-fcampbell
approved these changes
Sep 27, 2024
sfc-gh-bdufour
approved these changes
Sep 27, 2024
sfc-gh-turbaszek
approved these changes
Oct 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pre-review checklist
Changes description
Goal: Declarative way of creating test-data, to ultimately serve as a replacement for making more files and folders under tests/test-data/projects.
Changes:
Factory to create a PDF file (snowflake.yml and snowflake.local.yml for V1.*) with specified properties (look at this updated test for an example).
Same factory above can return a yml dict or a string of the PDF, without writing to disk, using the
build
method. Look at this updated test for the usage exampleProject Factory that can create PDF file with the specified properties, as well as other files with specified content. See
use_integration_project
for an example setup that recreatestests/test-data/projects/integration
TODO after this POC