Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SNOW-1708383 fix opening external browser on win #2053

Merged
merged 1 commit into from
Jan 29, 2025

Conversation

sfc-gh-mhofman
Copy link
Contributor

@sfc-gh-mhofman sfc-gh-mhofman commented Jan 29, 2025

Fix will rely on awt.desktop whenever possible and prevent falling back to xdg-open on Windows when java.awt.headless is enabled

Overview

SNOW-1708383

Pre-review self checklist

  • PR branch is updated with all the changes from master branch
  • The code is correctly formatted (run mvn -P check-style validate)
  • New public API is not unnecessary exposed (run mvn verify and inspect target/japicmp/japicmp.html)
  • The pull request name is prefixed with SNOW-XXXX:
  • Code is in compliance with internal logging requirements

External contributors - please answer these questions before submitting a pull request. Thanks!

  1. What GitHub issue is this PR addressing? Make sure that there is an accompanying issue to your PR.

    Issue: #NNNN

  2. Fill out the following pre-review checklist:

    • I am adding a new automated test(s) to verify correctness of my new code
    • I am adding new logging messages
    • I am modifying authorization mechanisms
    • I am adding new credentials
    • I am modifying OCSP code
    • I am adding a new dependency or upgrading an existing one
    • I am adding new public/protected component not marked with @SnowflakeJdbcInternalApi (note that public/protected methods/fields in classes marked with this annotation are already internal)
  3. Please describe how your code solves the related issue.

    Please write a short description of how your code change solves the related issue.

…top whenever possible; fixed executing browser when java.awt.headless is enabled
@sfc-gh-mhofman sfc-gh-mhofman requested a review from a team as a code owner January 29, 2025 10:50
@sfc-gh-dprzybysz sfc-gh-dprzybysz merged commit 4f01bb8 into master Jan 29, 2025
114 of 142 checks passed
@sfc-gh-dprzybysz sfc-gh-dprzybysz deleted the SNOW-1708383-fix-opening-external-browser branch January 29, 2025 11:33
@github-actions github-actions bot locked and limited conversation to collaborators Jan 29, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants