-
Notifications
You must be signed in to change notification settings - Fork 116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Local testing] Fixes various local testing bugs #2373
Conversation
All contributors have signed the CLA ✍️ ✅ |
I have read the CLA Document and I hereby sign the CLA |
1 similar comment
I have read the CLA Document and I hereby sign the CLA |
recheck |
Actually, I found another use case where the removed code block
is required. @sfc-gh-jrose I see you got assigned #2305, could you help out? |
@sfc-gh-jrose any change you can help out or review the pr? |
I will review and help merge this week. |
I've moved your fork into a branch in order to get our checks to run correctly. I've also added tests to ensure the examples provided pass. See #2410 |
Perfect, thanks. I guess this pr can be closed then. |
Which Jira issue is this PR addressing? Make sure that there is an accompanying issue to your PR.
Fixes SNOW-1668981
Fixes SNOW-1360263
Fixes SNOW-1668862
Fixes SNOW-1694649
Fixes SNOW-1707286
Fill out the following pre-review checklist:
Please describe how your code solves the related issue.
SNOW-1668981
The code block
wrongly overwrites the
expr_to_alias
of the columns in dataframeanti
(see minimal reproducible example in #2305). I am unsure when this code block would be desirable. Tests pass without them. Still, better for a maintainer to have a good look at this change. If it's required, we could make it optional under a condition yet to be determined.SNOW-1360263
The
windows
variable needs to be ordered by the order of the index inres_index
.SNOW-1668862
Literal columns were always created with
nullable=False
, which madelit(None)
columns fail. Now,lit(None)
returns a nullable column.SNOW-1694649
In the merge statement, filtering on the
join_condition
resulted in a dataframe with unordered indices. This resulted in a failure when callingnew_column[either_isna]
. Reseting the index solves the issue.SNOW-1707286
Can't operate on
None
and datetime. Return None directly.