Truncate long VARCHAR fields before casting (close #126)

snowplow-incubator · Oct 1, 2020 · 33eea4f · 33eea4f
1 parent 535b4a1
commit 33eea4f
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 4 deletions.
diff --git a/loader/src/main/scala/com.snowplowanalytics.snowflake.loader/ast/package.scala b/loader/src/main/scala/com.snowplowanalytics.snowflake.loader/ast/package.scala
@@ -52,10 +52,12 @@ package object ast {
 
   implicit object CastedColumnShow extends Show[Select.CastedColumn] {
     def show(column: Select.CastedColumn): String = {
-      val castedColumn = s"${column.originColumn}:${column.columnName}::${column.datatype.show}"
       column.substring match {
-        case Some(Substring(start, length)) => s"substr($castedColumn,$start,$length)"
-        case None => castedColumn
+        case Some(Substring(start, length)) =>
+          val columnName = s"${column.originColumn}:${column.columnName}"
+          s"substr($columnName,$start,$length)::${column.datatype.show}"
+        case None =>
+          s"${column.originColumn}:${column.columnName}::${column.datatype.show}"
       }
     }
   }

diff --git a/loader/src/test/scala/com/snowplowanalytics/snowflake/loader/ast/StatementSpec.scala b/loader/src/test/scala/com/snowplowanalytics/snowflake/loader/ast/StatementSpec.scala
@@ -80,7 +80,7 @@ class StatementSpec extends Specification {
 
     val result = input.getStatement.value
     val expected = "INSERT INTO not_atomic.events(one,two,three) " +
-      "SELECT orig_col:dest_column::VARIANT, orig_col:next::DOUBLE PRECISION, substr(orig_col:third::NUMBER(1,2),1,255) " +
+      "SELECT orig_col:dest_column::VARIANT, orig_col:next::DOUBLE PRECISION, substr(orig_col:third,1,255)::NUMBER(1,2) " +
       "FROM some_schema.tmp_table"
 
     result must beEqualTo(expected)