This repository has been archived by the owner on Sep 26, 2023. It is now read-only.
Release 0.9.2 #166
Merged
Release 0.9.2 #166
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Snyk was reporting security vulnerabilities in the Jackson libraries that are brough transitively from other libraries. In order to get rid of these vulnerabilities, we've added those libraries as dependency to project explicitly and bump their versions.
benjben
approved these changes
Aug 23, 2022
| @@ -67,6 +67,8 @@ lazy val transformer = project.in(file("transformer")) | |||
|
|
|||
| lazy val commonDependencies = Seq( | |||
| Dependencies.jacksonCbor, | |||
| Dependencies.jacksonDatabind, | |||
| Dependencies.jacksonScala, | |||
There was a problem hiding this comment.
What is the effect of adding jackson-module-scala to the deps? Given that jackson is a Java lib
There was a problem hiding this comment.
According to this, it provides serializers and deserializers for Scala entities like case class, Map, Option etc.
It was brought implicitly previously. When I've bumped jackson databind library version to 2.12.7, it threw error due to incompatibility with jackson scala library. Therefore, I've included it too explicitly and bumped its version.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Snyk was reporting security vulnerabilities in the Jackson libraries that are brough transitively from other libraries.
In order to get rid of these vulnerabilities, we've added those libraries as dependency to project explicitly and bump their versions.