Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add unified model docs #631

Merged
merged 8 commits into from
Nov 17, 2023
Merged

Add unified model docs #631

merged 8 commits into from
Nov 17, 2023

Conversation

agnessnowplow
Copy link
Contributor

@agnessnowplow agnessnowplow commented Oct 5, 2023

Waiting for decisions around licensing, (possible changes coming from there maybe) and then it needs to be merged as soon as the package is released.

@netlify
Copy link

netlify bot commented Oct 5, 2023

Deploy Preview for snowplow-docs ready!

Name Link
🔨 Latest commit 6c7f18d
🔍 Latest deploy log https://app.netlify.com/sites/snowplow-docs/deploys/6557423c8dac5100082749f9
😎 Deploy Preview https://deploy-preview-631--snowplow-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Comment on lines +16 to +23

**The package source code can be found in the [snowplow/dbt-snowplow-unified repo](https://github.com/snowplow/dbt-snowplow-unified), and the docs for the [model design here](https://snowplow.github.io/dbt-snowplow-unified/#!/overview/snowplow_unified).**

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure what license exactly this is going to be under or if it will be a public repo, so we may need to add the relevant header to these pages to call that out. @miike

@agnessnowplow agnessnowplow force-pushed the feature/add_unified_package branch from e2deeb6 to 698b42a Compare October 6, 2023 12:43
@rlh1994
Copy link
Contributor

rlh1994 commented Oct 9, 2023

We should probably add a bit "BETA" banner or something to each of these pages until we are out of release-candidates?

@agnessnowplow agnessnowplow marked this pull request as ready for review October 17, 2023 11:53
Copy link
Contributor

@rlh1994 rlh1994 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a load of random stuff

Copy link
Contributor

@rlh1994 rlh1994 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few small bits but really nice!

@agnessnowplow agnessnowplow added the do not merge Flag to denote a Issue or PR which should not yet be merged (usually pending a release) label Oct 26, 2023
agnessnowplow and others added 3 commits November 16, 2023 18:08
* Update utils dbt docs

* Add on normalize changes

---------

Co-authored-by: Emiel <emiel.verkade@gmail.com>
@agnessnowplow agnessnowplow force-pushed the feature/add_unified_package branch from 46c39ad to b33d647 Compare November 16, 2023 18:08
src/componentVersions.js Outdated Show resolved Hide resolved
@agnessnowplow agnessnowplow merged commit 296c995 into main Nov 17, 2023
4 checks passed
@agnessnowplow agnessnowplow deleted the feature/add_unified_package branch November 17, 2023 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla:yes do not merge Flag to denote a Issue or PR which should not yet be merged (usually pending a release)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants