Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepend underscore for parquet fields starting with number #209

Merged
merged 1 commit into from
Sep 9, 2024

Conversation

oguzhanunlu
Copy link
Member

ref: PDP-1396

@oguzhanunlu oguzhanunlu self-assigned this Sep 9, 2024
@oguzhanunlu oguzhanunlu changed the base branch from master to develop September 9, 2024 13:35
@coveralls
Copy link

Pull Request Test Coverage Report for Build 10774362679

Details

  • 3 of 3 (100.0%) changed or added relevant lines in 1 file are covered.
  • 7 unchanged lines in 6 files lost coverage.
  • Overall coverage increased (+0.3%) to 80.692%

Files with Coverage Reduction New Missed Lines %
modules/core/src/main/scala/com.snowplowanalytics/iglu.schemaddl/jsonschema/circe/NumberCodecs.scala 1 70.37%
modules/core/src/main/scala/com.snowplowanalytics/iglu.schemaddl/parquet/Migrations.scala 1 90.67%
modules/core/src/main/scala/com.snowplowanalytics/iglu.schemaddl/jsonschema/package.scala 1 61.76%
modules/core/src/main/scala/com.snowplowanalytics/iglu.schemaddl/jsonschema/circe/StringCodecs.scala 1 71.43%
modules/core/src/main/scala/com.snowplowanalytics/iglu.schemaddl/jsonschema/mutate/Widened.scala 1 87.27%
modules/core/src/main/scala/com.snowplowanalytics/iglu.schemaddl/bigquery/Row.scala 2 71.79%
Totals Coverage Status
Change from base Build 10216606864: 0.3%
Covered Lines: 1283
Relevant Lines: 1590

💛 - Coveralls

@oguzhanunlu oguzhanunlu merged commit 6c989fd into develop Sep 9, 2024
3 checks passed
@oguzhanunlu oguzhanunlu deleted the PDP-1396 branch September 9, 2024 13:42
istreeter added a commit to snowplow-incubator/snowplow-lake-loader that referenced this pull request Sep 20, 2024
The following improvements are introduced via common-streams 0.8.0-M4:

- Fields starting with a digit are now prefixed with an underscore `_`.
  This is needed for Hudi, which does not allow fields starting with a
  digit (snowplow/schema-ddl#209)
- New kinesis source implementation without fs2-kinesis
  (snowplow-incubator/common-streams#84)
- Iglu schemas are resolved in parallel, for short pause times during
  event processing (snowplow-incubator/common-streams#85)
- Common http client configured with restricted max connections per
  server (snowplow-incubator/common-streams#87)
- Iglu scala client 3.2.0 no longer relies on the "list" schemas
  endpoint (snowplow/iglu-scala-client#255)
istreeter added a commit to snowplow-incubator/snowplow-lake-loader that referenced this pull request Sep 20, 2024
The following improvements are introduced via common-streams 0.8.0-M4:

- Fields starting with a digit are now prefixed with an underscore `_`.
  This is needed for Hudi, which does not allow fields starting with a
  digit (snowplow/schema-ddl#209)
- New kinesis source implementation without fs2-kinesis
  (snowplow-incubator/common-streams#84)
- Iglu schemas are resolved in parallel, for short pause times during
  event processing (snowplow-incubator/common-streams#85)
- Common http client configured with restricted max connections per
  server (snowplow-incubator/common-streams#87)
- Iglu scala client 3.2.0 no longer relies on the "list" schemas
  endpoint (snowplow/iglu-scala-client#255)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants