Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Content-Disposition header in case of filenames with unicode characters or spaces #68

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Fix Content-Disposition header in case of filenames with unicode characters or spaces #68

wants to merge 3 commits into from

Commits on Jul 13, 2022

  1. Fix Content-Disposition header - filename rendering 

    Instead of

    Content-Disposition: "attachment; file=a b.pdf"

this outputs

    Content-Disposition: attachment; file="a b.pdf"

The quotation marks are introduced always; therefore this breaks
compatibility if filenames are quoted manually. Then again, the
quotation marks around "attachment; file=..." where introduced
before this change already if e.g. the filename contained umlaute
and didn't respect quoted filenames.
    @jbuchermn
    jbuchermn committed Jul 13, 2022
    Configuration menu
    Copy the full SHA
    c1e295e View commit details
    Browse the repository at this point in the history

Commits on Jul 14, 2022

  1. Additional quotes are not necessary

    @jbuchermn
    jbuchermn committed Jul 14, 2022
    Configuration menu
    Copy the full SHA
    0e22db7 View commit details
    Browse the repository at this point in the history

Commits on Jul 18, 2022

  1. Simpler way of exposing the functionality

    @jbuchermn
    jbuchermn committed Jul 18, 2022
    Configuration menu
    Copy the full SHA
    a603ca0 View commit details
    Browse the repository at this point in the history