Fix can't scroll if camera's viewport rect is modified #1029
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the camera's rect doesn't use the whole screen, scrolling snaps to one of the screen sides. This fixes it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When the camera's rect doesn't use the whole screen, scrolling snaps to one of the screen sides. This fixes it.
A quick way to view this problem is to click on the camera and change any of the viewport values. After that, swipping will stop working.
What is the current behavior?
If the camera's rect isn't the default one, the scroll on a swipe element will automatically be performed without any user input. This happens because it's assumed that the viewport matches the camera's viewport rect, but it isn't always true.
What is the new behavior?
Now swipping always works instead of only when the screen rect is ok.
Important Notes
None
Other information
None