93

snuyanzin · Mar 19, 2024 · d3448f6 · d3448f6
1 parent e1d01ab
commit d3448f6
Show file tree

Hide file tree

Showing 7 changed files with 10 additions and 14 deletions.
diff --git a/...core/src/main/java/org/apache/flink/api/common/operators/util/ListKeyGroupedIterator.java b/...core/src/main/java/org/apache/flink/api/common/operators/util/ListKeyGroupedIterator.java
@@ -64,7 +64,7 @@ public ListKeyGroupedIterator(
         this.serializer = serializer;
         this.comparator = comparator;
 
-        this.done = input.isEmpty() ? true : false;
+        this.done = input.isEmpty();
     }
 
     /**

diff --git a/...c/main/java/org/apache/flink/runtime/checkpoint/channel/SequentialChannelStateReader.java b/...c/main/java/org/apache/flink/runtime/checkpoint/channel/SequentialChannelStateReader.java
@@ -1,4 +1,3 @@
-package org.apache.flink.runtime.checkpoint.channel;
 /*
  * Licensed to the Apache Software Foundation (ASF) under one or more
  * contributor license agreements.  See the NOTICE file distributed with
@@ -16,6 +15,8 @@
  * limitations under the License.
  */
 
+package org.apache.flink.runtime.checkpoint.channel;
+
 import org.apache.flink.annotation.Internal;
 import org.apache.flink.runtime.io.network.api.writer.ResultPartitionWriter;
 import org.apache.flink.runtime.io.network.partition.consumer.InputGate;

diff --git a/flink-runtime/src/main/java/org/apache/flink/runtime/rest/handler/job/JobPlanHandler.java b/flink-runtime/src/main/java/org/apache/flink/runtime/rest/handler/job/JobPlanHandler.java
@@ -1,4 +1,3 @@
-package org.apache.flink.runtime.rest.handler.job;
 /*
  * Licensed to the Apache Software Foundation (ASF) under one
  * or more contributor license agreements.  See the NOTICE file
@@ -17,6 +16,8 @@
  * limitations under the License.
  */
 
+package org.apache.flink.runtime.rest.handler.job;
+
 import org.apache.flink.api.common.time.Time;
 import org.apache.flink.runtime.executiongraph.AccessExecutionGraph;
 import org.apache.flink.runtime.rest.handler.HandlerRequest;

diff --git a/...statebackend-changelog/src/main/java/org/apache/flink/state/changelog/ChangelogState.java b/...statebackend-changelog/src/main/java/org/apache/flink/state/changelog/ChangelogState.java
@@ -1,4 +1,3 @@
-package org.apache.flink.state.changelog;
 /*
  * Licensed to the Apache Software Foundation (ASF) under one or more
  * contributor license agreements.  See the NOTICE file distributed with
@@ -16,6 +15,8 @@
  * limitations under the License.
  */
 
+package org.apache.flink.state.changelog;
+
 import org.apache.flink.annotation.Internal;
 import org.apache.flink.state.changelog.restore.ChangelogApplierFactory;
 import org.apache.flink.state.changelog.restore.StateChangeApplier;

diff --git a/...way/src/main/java/org/apache/flink/table/gateway/service/operation/OperationExecutor.java b/...way/src/main/java/org/apache/flink/table/gateway/service/operation/OperationExecutor.java
@@ -783,7 +783,7 @@ public ResultFetcher callShowJobsOperation(
      * @param handle the specified operation handle
      * @param clusterAction the cluster action to run against the retrieved {@link ClusterClient}.
      * @param <ClusterID> type of the cluster id
-     * @param <Result>> type of the result
+     * @param <Result> type of the result
      * @throws SqlExecutionException if something goes wrong
      */
     private <ClusterID, Result> Result runClusterAction(

diff --git a/pom.xml b/pom.xml
@@ -2169,13 +2169,13 @@ under the License.
 				<plugin>
 					<groupId>org.apache.maven.plugins</groupId>
 					<artifactId>maven-checkstyle-plugin</artifactId>
-					<version>3.1.2</version>
+					<version>3.3.1</version>
 					<dependencies>
 						<dependency>
 							<groupId>com.puppycrawl.tools</groupId>
 							<artifactId>checkstyle</artifactId>
 							<!-- Note: match version with docs/flinkDev/ide_setup.md -->
-							<version>8.20</version>
+							<version>9.3</version>
 						</dependency>
 					</dependencies>
 					<executions>

diff --git a/tools/maven/checkstyle.xml b/tools/maven/checkstyle.xml
@@ -238,16 +238,9 @@ This file is based on the checkstyle file of Apache Beam.
 		<!-- Checks for Javadoc comments.                     -->
 		<!-- See http://checkstyle.sf.net/config_javadoc.html -->
 		<module name="JavadocMethod">
-			<property name="scope" value="protected"/>
 			<property name="severity" value="error"/>
-			<property name="allowMissingJavadoc" value="true"/>
 			<property name="allowMissingParamTags" value="true"/>
 			<property name="allowMissingReturnTag" value="true"/>
-			<property name="allowMissingThrowsTags" value="true"/>
-			<property name="allowThrowsTagsForSubclasses" value="true"/>
-			<property name="allowUndeclaredRTE" value="true"/>
-			<!-- This check sometimes failed for with "Unable to get class information for @throws tag" for custom exceptions -->
-			<property name="suppressLoadErrors" value="true"/>
 		</module>
 
 		<!-- Check that paragraph tags are used correctly in Javadoc. -->