Feat: allow custom ruby file names #1345
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested review from
lili2311
force-pushed
the
feat/allow-custom-ruby-file-names
branch
2 times, most recently
from
1eb9086 to
865c2da
Compare
lili2311
changed the title
lili2311
force-pushed
the
feat/allow-custom-ruby-file-names
branch
from
865c2da to
54c92ce
Compare
Allow custom ruby file names to be tested when scanned with: snyk test --file=rails.2.4.5.gemfile --package-manager=rubygems snyk monitor --file=gemfiles/Gemfile.lock.rails-2.4.5 --package-manager=rubygems
lili2311
force-pushed
the
feat/allow-custom-ruby-file-names
branch
from
54c92ce to
42b3a51
Compare
|
Expected release notes (by @lili2311) features: others (will not be included in Semantic-Release notes):
|
3 tasks
orsagie
approved these changes
Aug 19, 2020
anthogez
reviewed
Aug 19, 2020
| @@ -42,6 +41,80 @@ export const RubyTests: AcceptanceTests = { | |||
| ); | |||
| }, | |||
|
|
|||
| '`test ruby-app-custom-names --file=123.gemfile.lock --package-manager=rubygems`': ( | |||
There was a problem hiding this comment.
Could you add a test where we test also e.g. rails.2.4.5.gemfile files and not only lockfiles? Thanks!
There was a problem hiding this comment.
|
🎉 This PR is included in version 1.379.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Allow custom ruby file names to be tested when scanned with:
snyk test --file=rails.2.4.5.gemfile --package-manager=rubygemssnyk monitor --file=gemfiles/Gemfile.lock.rails-2.4.5 --package-manager=rubygemsWhere should the reviewer start?
https://github.com/snyk/snyk/compare/feat/allow-custom-ruby-file-names?expand=1#diff-4871998b3f946a79dad807557f130ed6R5
Relies on this PR: #1344