Improve smoke tests dev experience #1767
Conversation
JackuB
force-pushed
the
smoke/improve-shellspec
branch
4 times, most recently
from
b80363e to
ca471d5
Compare
| exit 1 | ||
| fi | ||
| echo "Installing shellspec with brew" | ||
| brew install shellspec |
There was a problem hiding this comment.
this is mac specific, do we plan on making linux/windows scripts later on?
There was a problem hiding this comment.
I've looked into that, but I gave up
| ███████╗██╔████╔██║██║ ██║█████╔╝ █████╗ ██║ █████╗ ███████╗ ██║ ███████╗ | ||
| ╚════██║██║╚██╔╝██║██║ ██║██╔═██╗ ██╔══╝ ██║ ██╔══╝ ╚════██║ ██║ ╚════██║ | ||
| ███████║██║ ╚═╝ ██║╚██████╔╝██║ ██╗███████╗ ██║ ███████╗███████║ ██║ ███████║ | ||
| ╚══════╝╚═╝ ╚═╝ ╚═════╝ ╚═╝ ╚═╝╚══════╝ ╚═╝ ╚══════╝╚══════╝ ╚═╝ ╚══════╝ |
| #!/usr/bin/env bash | ||
| set -e | ||
|
|
||
| echo "Attempting to run Smoke Tests locally. See file 'test/smoke/README.md' for details. This will drop your local 'snyk config'!" |
There was a problem hiding this comment.
Could you make a back up of the local config file (if it exists) before proceeding?
There was a problem hiding this comment.
It gets complicated in guessing the config location - would be a bit easier if snyk config would have a command to let you know which config it is using
| @@ -2,11 +2,10 @@ | |||
|
|
|||
| echo "install snyk with binary" | |||
| snyk_cli_dl=$(curl -H "Authorization: token $GITHUB_TOKEN" https://api.github.com/repos/snyk/snyk/releases/latest | jq --raw-output '(.assets[])? | select(.name == "snyk-alpine") | .browser_download_url') | |||
| echo "snyk_cli_dl: ${snyk_cli_dl}" | |||
| curl -Lo ./snyk-cli $snyk_cli_dl | |||
| echo "snyk_cli_dl: $snyk_cli_dl" | |||
There was a problem hiding this comment.
I would have thought you'd want the { / }.
There was a problem hiding this comment.
You don't need (or want?) the parameter expansion {} if you are just printing it afaik
JackuB
force-pushed
the
smoke/improve-shellspec
branch
from
ca471d5 to
ed89c16
Compare
JackuB
force-pushed
the
smoke/improve-shellspec
branch
from
ed89c16 to
9002fcc
Compare
|
Merging, as it'll allow me to open another PR that will speed up the builds and allow better testing for monorepo cases such as #1707 |
Updates the ad hoc experience of running smoke tests locally
Checkout the readme changes: https://github.com/snyk/snyk/blob/smoke/improve-shellspec/test/smoke/README.md