feat:support constraints.txt pinning #1790
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lili2311
changed the title
No longer skip fixing pip manifests that include `-c somefile.txt` to reference the constraints.
When a constraints file is present and referenced via `-c` in a requirements.txt file, make sure to add pins of transitive dependencies there instead of in the main manifest.
lili2311
force-pushed
the
feat/support-constraints-pinning
branch
from
babca87 to
eae3c87
Compare
aarlaud
approved these changes
Apr 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Support manifests that contain
-c constraints.txtdirective. When a constraints file is present it is used for reference of what version a certain dependency if installed should be, it is not used to install the dependencies.If present this is the relevant place to add any transitive dependency pins + another place to bump any versions that are vulnerable.