Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: migrate is-docker to jest #2180

Merged
merged 1 commit into from
Aug 23, 2021
Merged

test: migrate is-docker to jest #2180

merged 1 commit into from
Aug 23, 2021

Conversation

Avishagp
Copy link
Contributor

@Avishagp Avishagp commented Aug 22, 2021 •
edited
Loading

Migrate is-docker to jest, including sinon usage

@Avishagp Avishagp requested review from a team as code owners August 22, 2021 14:28
@Avishagp Avishagp requested a review from admons August 22, 2021 14:28
@github-actions
Copy link
Contributor

github-actions bot commented Aug 22, 2021 •
edited
Loading

Messages
📖

This PR will not trigger a new version. It doesn't include any commit message with feat or fix.

Generated by 🚫 dangerJS against 95631e7

@Avishagp Avishagp force-pushed the test/migrate-is-docker branch from 14012a1 to 391ce7a Compare August 23, 2021 08:20
@Avishagp Avishagp requested a review from anthogez August 23, 2021 08:21
@Avishagp Avishagp force-pushed the test/migrate-is-docker branch from 391ce7a to e4ee8ea Compare August 23, 2021 09:15
@Avishagp Avishagp requested a review from anthogez August 23, 2021 09:37
@Avishagp Avishagp force-pushed the test/migrate-is-docker branch from e4ee8ea to e7f700f Compare August 23, 2021 09:43
@Avishagp Avishagp requested a review from anthogez August 23, 2021 12:27
ghost
ghost approved these changes Aug 23, 2021
View reviewed changes
test/jest/unit/is-docker.spec.ts Show resolved Hide resolved
test/jest/unit/is-docker.spec.ts Outdated Show resolved Hide resolved
test/jest/unit/is-docker.spec.ts Outdated Show resolved Hide resolved
@Avishagp Avishagp force-pushed the test/migrate-is-docker branch from e7f700f to 95631e7 Compare August 23, 2021 12:46
@Avishagp Avishagp merged commit 418e6ad into master Aug 23, 2021
@Avishagp Avishagp deleted the test/migrate-is-docker branch August 23, 2021 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@admons admons Awaiting requested review from admons

@anthogez anthogez Awaiting requested review from anthogez

Assignees

@Avishagp Avishagp

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Avishagp @anthogez