-
Notifications
You must be signed in to change notification settings - Fork 561
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: upgrade danger-js #2347
chore: upgrade danger-js #2347
Conversation
There is some extra output compared to the usual output like on this other PR, but the Danger message gets posted:
|
Tempted to drop the custom action and use manual steps instead with a call to https://github.com/danger/danger-js/blob/10.7.1/source/ci_source/providers/GitHubActions.ts |
ad8b8dc
to
9ce752a
Compare
Those 403 errors seem to be related to this: danger/danger-js#1031 |
411eeed
to
9ce752a
Compare
Looks like the newer versions edit the existing message rather than delete and re-post new ones (causing notification spam). Nice. |
2e3559c
to
9ce752a
Compare
Noticed our DangerJS GitHub Action is old and out of sync with the one we use to write our scripts. So I've synced them and upgraded the version to latest. No breaking changes AFAIK.