-
Notifications
You must be signed in to change notification settings - Fork 561
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
change msg when missing = in key=value #2350
change msg when missing = in key=value #2350
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pre-approving, but just update the commit and error messages 👌
src/cli/commands/monitor/index.ts
Outdated
@@ -426,7 +426,7 @@ export function generateTags(options): Tag[] | undefined { | |||
const parts = keyEqualsValue.split('='); | |||
if (parts.length !== 2) { | |||
throw new ValidationError( | |||
`The tag "${keyEqualsValue}" does not have an "=" separating the key and value.`, | |||
`The tag "${keyEqualsValue}" does not have an "=" separating the key and value. eg: --project-tag=KEY=VALUE`, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
`The tag "${keyEqualsValue}" does not have an "=" separating the key and value. eg: --project-tag=KEY=VALUE`, | |
`The tag "${keyEqualsValue}" does not have an "=" separating the key and value. E.g. --project-tag=KEY=VALUE`, |
Or
`The tag "${keyEqualsValue}" does not have an "=" separating the key and value. eg: --project-tag=KEY=VALUE`, | |
`The tag "${keyEqualsValue}" does not have an "=" separating the key and value. For example --project-tag=KEY=VALUE`, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, done 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, done 👍
5c7aee3
to
edb2006
Compare
edb2006
to
8b479b9
Compare
What does this PR do?
This PR changes the error message when the user supplies --project-tags=THING : instead of getting the error:
The tag "XXX" does not have an "=" separating the key and value.
User will now get the error:
The tag "XXX" does not have an "=" separating the key and value. eg: --project-tag=KEY=VALUE
https://github.com/snyk/snyk/blob/afe15c7fad3baddb8958bcdc979894aba5bf30b8/src/cli/commands/monitor/index.ts#L429