-
Notifications
You must be signed in to change notification settings - Fork 561
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: migrate cli tap tests to jest #2351
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ghost
force-pushed
the
test/migrate-cli-test-to-jest
branch
from
November 30, 2021 12:16
8b4c2d8
to
bebac90
Compare
ghost
changed the title
test: migrate cli test to jest
test: migrate cli tap tests to jest
Nov 30, 2021
ghost
force-pushed
the
test/migrate-cli-test-to-jest
branch
5 times, most recently
from
November 30, 2021 15:48
bb0cc2c
to
86177cc
Compare
ghost
force-pushed
the
test/migrate-cli-test-to-jest
branch
from
November 30, 2021 16:24
86177cc
to
6b6ae86
Compare
ghost
mentioned this pull request
Dec 2, 2021
This was referenced Jan 16, 2022
This was referenced Feb 3, 2022
ghost
closed this
Mar 25, 2022
This was referenced Apr 7, 2022
This was referenced Sep 22, 2022
This was referenced Sep 24, 2022
This was referenced Sep 26, 2022
This was referenced Oct 1, 2022
This was referenced Oct 3, 2022
This was referenced Feb 19, 2023
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
None yet
0 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP
Follow up to #2343 and #2265
system/cli.test.ts
contains a bunch of tests ranging from auth, test, monitor, policy and more. There are issues with how they setup and cleanup which causes a single test failure to fail the rest of them. Likely because they use Restify via cli-server which isn't supported in Node 16 (see #2265). So I've started migrating them to Jest and fake-server.Auth in Tests
A lot of tests use
snyk config
to setup/teardown authentication. These need to be migrated to env vars assnyk config
uses a global config file causing cross-test pollution. One simple option is to make the config path configurable.To Do