-
Notifications
You must be signed in to change notification settings - Fork 561
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Improve output for dockerfile instructions #2353
Conversation
|
166c31a
to
0aaaf72
Compare
I think we actually could release the SDP first, and add that bump here, so we only raise the cli PR once |
a6cde6d
to
ca2c254
Compare
1c0d90c
to
06bd47c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! I'd suggest find/replacing all usages of "instruction" in this context to "install command" in test names, variable names, etc. It's confusing/inconsistent otherwise.
This commit allows for use of the installCommand extracted from a RUN instruction in newer versions of the SDP. [CAP-280]
06bd47c
to
4690660
Compare
What does this PR do?
This PR allows for use of the installCommand, extracted from a RUN instruction in newer versions of the SDP, to provide a better output for dockerFile user instructions.
https://snyksec.atlassian.net/browse/CAP-280