Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci): migrate to cimg images #2413

Merged
1 commit merged into from
Jan 5, 2022
Merged

chore(ci): migrate to cimg images #2413

1 commit merged into from
Jan 5, 2022

Conversation

ghost
Copy link

@ghost ghost commented Dec 2, 2021

Old images won't be maintained after December 2021. So this PR migrates us to the new ones.

https://discuss.circleci.com/t/legacy-convenience-image-deprecation/41034

Not using Node Orb

CircleCI's "node" orb handles caching for us so I tried using cimg/base since our Node version varies. However, it has too many issues and limitations.

  • It doesn't support ramdisk (it attempts some symlink wizardry and fails, see below).
  • It doesn't support Windows.
  • We still need to configure NPM_TOKEN using npm config.
ln: failed to create hard link '/tmp/node-project-lockfile' => 'package-lock.json': Invalid cross-device link

So in general, it's simpler to keep using a Node image and maintain our existing manual caches and configuration.

@github-actions
Copy link
Contributor

github-actions bot commented Dec 2, 2021

Messages
📖

This PR will not trigger a new version. It doesn't include any commit message with feat or fix.

Generated by 🚫 dangerJS against 600d735

@ghost ghost force-pushed the chore/cimg branch 3 times, most recently from bb1c942 to 9262da6 Compare December 2, 2021 20:16
@ghost ghost force-pushed the chore/cimg branch 5 times, most recently from 8562a07 to 88888ed Compare December 31, 2021 15:43
@ghost ghost marked this pull request as ready for review December 31, 2021 17:28
@ghost ghost requested review from a team as code owners December 31, 2021 17:28
@ghost ghost requested review from almog27, admons and Jdunsby December 31, 2021 17:28
@ghost ghost merged commit d9494db into master Jan 5, 2022
@ghost ghost deleted the chore/cimg branch January 5, 2022 13:28
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant