chore(ci): migrate to cimg images #2413
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
force-pushed
the
chore/cimg
branch
3 times, most recently
from
bb1c942
to
9262da6
Compare
ghost
force-pushed
the
chore/cimg
branch
5 times, most recently
from
8562a07
to
88888ed
Compare
ghost
marked this pull request as ready for review
Avishagp
approved these changes
Jan 5, 2022
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Old images won't be maintained after December 2021. So this PR migrates us to the new ones.
https://discuss.circleci.com/t/legacy-convenience-image-deprecation/41034
Not using Node Orb
CircleCI's "node" orb handles caching for us so I tried using
cimg/basesince our Node version varies. However, it has too many issues and limitations.NPM_TOKENusingnpm config.So in general, it's simpler to keep using a Node image and maintain our existing manual caches and configuration.