Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: get stdout failure text before exit code #3097

Merged
merged 1 commit into from
Apr 5, 2022

Conversation

ipapast
Copy link
Contributor

@ipapast ipapast commented Apr 5, 2022

This is a non functional change, just reordering the assertions in our iac acceptance tests.

So far, if a test fails - we will only see the exit code assertion and not the actual reason why.
This commit moves all exit code assertions from the top assertion to the bottom.
In this way we can see the stdout actual text first when a test fails. It will be even easier for checking it in CircleCI.

example before:

image

@ipapast ipapast requested a review from francescomari April 5, 2022 15:11
This commit moves all exit code assertions from the top assertion to the bottom.
In this way we can see the stdout actual text first when a test fails. It will be even easier for checking it in CircleCI.
@ipapast ipapast force-pushed the test/update-iac-test-exit-code-assert branch from b232184 to 8c392a4 Compare April 5, 2022 15:19
@ipapast ipapast marked this pull request as ready for review April 5, 2022 15:27
@ipapast ipapast requested a review from a team as a code owner April 5, 2022 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants