feat: OS CLI output part I - update severity headline +test #3437
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| ) + | ||
| reachabilityText + | ||
| '\n ' + |
There was a problem hiding this comment.
Wondering you should use \t instead of to be more explicit, if the intention is for it to be tabbed?
danielroymoore
previously approved these changes
Jul 15, 2022
- Severity and Title should be the only content on the line, similar to the web/ide - [Severity] should be the first, in front of the title, similar to web/ide - Removing the word ‘severity’ and only keeping [Critical], [High], [Medium], [Low] - Proper color usage (e.g. Green shouldn’t be used for section titles)
florindumitrascu
force-pushed
the
feat/os-cli-output+test
branch
from
5103fa8 to
305de41
Compare
florindumitrascu
changed the title
florindumitrascu
changed the title
florindumitrascu
changed the title
Merge from branch 'master' into 'feat/os-cli-output+test'
florindumitrascu
force-pushed
the
feat/os-cli-output+test
branch
from
d9f28cf to
e7a7b04
Compare
Avishagp
approved these changes
Jul 29, 2022
This was referenced Nov 28, 2023
|
🧹 Closing as stale. No activity in more than 1 year. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Improve snyk-open-source CLI output as follows:
Where should the reviewer start?
src/lib/formatters/remediation-based-format-issues.ts
How should this be manually tested?
Run 'snyk test' command on a local project and compare output formatting with the attached screenshot
Any background context you want to provide?
What are the relevant tickets?
TUN-269
Screenshots
Additional questions