Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: base64 default for sast analysis #4214

Merged
merged 1 commit into from
Nov 28, 2022
Merged

feat: base64 default for sast analysis #4214

merged 1 commit into from
Nov 28, 2022

Conversation

soniqua
Copy link
Contributor

@soniqua soniqua commented Nov 17, 2022

What does this PR do?

  • Removes any configuration related to the base64Encoding flag
  • Updates code-client, wherein base64 Encoding of Snyk Code payloads is enabled by default
  • Removes any tests written for the inclusion of the base64Encoding flag

Where should the reviewer start?

  • Changes for sast plugins.

How should this be manually tested?

  • Run a snyk code test command using the locally built CLI and ensure payloads are gzipped/encoded on transmission (can see from either debug logs or an intermediate proxy).

Any background context you want to provide?

What are the relevant tickets?

Screenshots

Additional questions

@ghost
Copy link

ghost commented Nov 17, 2022

This PR modifies files linked to issues tracked in Stepsize. You might want to review their status, priority, and scope.

✅  2 http libraries in CLI
  • src/lib/plugins/sast/analysis.ts
Created from GitHub PR snyk/snyk/#2826
  • src/lib/plugins/sast/analysis.ts

 Mention [stepsize] in a comment if you'd like to report some technical debt. See examples here.

@github-actions
Copy link
Contributor

Warnings
⚠️

Since the CLI is unifying on a standard and improved tooling, we're starting to migrate old-style imports and exports to ES6 ones.
A file you've modified is using either module.exports or require(). If you can, please update them to ES6 import syntax and export syntax.
Files found:

  • test/jest/unit/snyk-code/snyk-code-test.spec.ts

Generated by 🚫 dangerJS against 369fe11

@soniqua soniqua marked this pull request as ready for review November 17, 2022 17:12
@soniqua soniqua requested a review from a team as a code owner November 17, 2022 17:12
@soniqua soniqua requested a review from a team November 17, 2022 17:12
@soniqua soniqua requested review from a team as code owners November 17, 2022 17:12
@soniqua soniqua merged commit 3daf5c7 into master Nov 28, 2022
@soniqua soniqua deleted the feat/base64-default branch November 28, 2022 11:41
@ghost
Copy link

ghost commented Nov 28, 2022

This PR modifies files linked to issues tracked in Stepsize. You might want to review their status, priority, and scope.

✅  2 http libraries in CLI
  • src/lib/plugins/sast/analysis.ts
Created from GitHub PR snyk/snyk/#2826
  • src/lib/plugins/sast/analysis.ts

 Mention [stepsize] in a comment if you'd like to report some technical debt. See examples here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants