Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update Go version to 1.21.1 #4873

Closed
wants to merge 1 commit into from
Closed

Conversation

cat2608
Copy link
Contributor

@cat2608 cat2608 commented Sep 22, 2023

What does this PR do?

This PR updates Go version to 1.21.1 https://go.dev/doc/devel/release

@cat2608 cat2608 requested a review from a team as a code owner September 22, 2023 11:20
@cat2608 cat2608 changed the title chore: update Go version to 1.21.1 and introduce toolchain directive chore: update Go version to 1.21.1 Sep 22, 2023
default: '1.20.6'
default: '1.21.1'
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have checked that download_go.py script will download the correct binary when passing 1.21.1

go-for-windows

@cat2608 cat2608 force-pushed the chore/update-go-version branch from 18e3471 to 6ad87e0 Compare September 22, 2023 11:36
@bastiandoetsch
Copy link
Contributor

I started that last week here: #4854. Maybe helpful, maybe not :)

The toolchain directive was introduced in Go 1.21.
@cat2608 cat2608 force-pushed the chore/update-go-version branch from 6ad87e0 to b075df6 Compare September 22, 2023 11:55
@cat2608 cat2608 closed this Sep 25, 2023
@cat2608 cat2608 deleted the chore/update-go-version branch September 25, 2023 07:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants