Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: apply refactorings from a previous PR #4896

Merged
merged 6 commits into from
Oct 9, 2023

Conversation

PeterSchafer
Copy link
Collaborator

What does this PR do?

  • Reduce size of main.go, by moving some functions to a separate file
  • renaming function to make more sense
  • ...

Where should the reviewer start?

How should this be manually tested?

Any background context you want to provide?

What are the relevant tickets?

Screenshots

Additional questions

@PeterSchafer PeterSchafer requested a review from a team as a code owner October 5, 2023 13:59
Copy link
Contributor

@bastiandoetsch bastiandoetsch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice

@PeterSchafer PeterSchafer force-pushed the chore/HEAD-861_apply_pr_comments branch from 00808ff to 3180f74 Compare October 5, 2023 16:49
@PeterSchafer PeterSchafer merged commit 2dab7ba into master Oct 9, 2023
5 checks passed
@PeterSchafer PeterSchafer deleted the chore/HEAD-861_apply_pr_comments branch October 9, 2023 07:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants