Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix :[SUP-2193] Fix v2 .net parsing not honoring missing rids. #4927

Merged
merged 2 commits into from
Nov 13, 2023
Merged

fix :[SUP-2193] Fix v2 .net parsing not honoring missing rids. #4927

merged 2 commits into from
Nov 13, 2023

Conversation

dotkas
Copy link
Contributor

@dotkas dotkas commented Nov 9, 2023

@dotkas dotkas requested review from a team as code owners November 9, 2023 10:40
@dotkas dotkas force-pushed the dotkas/SUP-2193/fix-nuget-rid-issue branch from 9fd0ecf to dabb3a7 Compare November 9, 2023 10:40
@dotkas dotkas enabled auto-merge (squash) November 9, 2023 10:43
@bastiandoetsch bastiandoetsch self-assigned this Nov 9, 2023
bastiandoetsch
bastiandoetsch requested changes Nov 9, 2023
View reviewed changes
Copy link
Contributor

@bastiandoetsch bastiandoetsch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Request changes: please update against main :). Voting against a release on a Friday :)

@dotkas
Copy link
Contributor Author

dotkas commented Nov 9, 2023

Request changes: please update against main :). Voting against a release on a Friday :)

Yeah, it's no problem. Also it disclosed a bug, so let's revisit next week.

@dotkas dotkas force-pushed the dotkas/SUP-2193/fix-nuget-rid-issue branch 2 times, most recently from 112b3f5 to a34faa6 Compare November 10, 2023 09:56
@dotkas dotkas force-pushed the dotkas/SUP-2193/fix-nuget-rid-issue branch from a34faa6 to 0f1c4ff Compare November 13, 2023 12:35
bastiandoetsch
bastiandoetsch reviewed Nov 13, 2023
View reviewed changes
Copy link
Contributor

@bastiandoetsch bastiandoetsch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unblocked

@dotkas dotkas merged commit b162130 into master Nov 13, 2023
5 checks passed
@dotkas dotkas deleted the dotkas/SUP-2193/fix-nuget-rid-issue branch November 13, 2023 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bastiandoetsch bastiandoetsch bastiandoetsch approved these changes

@JamesPatrickGill JamesPatrickGill JamesPatrickGill approved these changes

Assignees

@bastiandoetsch bastiandoetsch

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dotkas @bastiandoetsch @JamesPatrickGill