Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci): introduce caching around npm install step #5110

Merged
merged 1 commit into from
Mar 26, 2024

Conversation

thisislawatts
Copy link
Member

@thisislawatts thisislawatts commented Mar 12, 2024

Pull Request Submission

Please check the boxes once done.

The pull request must:

  • Reviewer Documentation
    • follow CONTRIBUTING rules
    • be accompanied by a detailed description of the changes
    • contain a risk assessment of the change (Low | Medium | High) with regards to breaking existing functionality. A change e.g. of an underlying language plugin can completely break the functionality for that language, but appearing as only a version change in the dependencies.
    • highlight breaking API if applicable
    • contain a link to the automatic tests that cover the updated functionality.
    • contain testing instructions in case that the reviewer wants to manual verify as well, to add to the manual testing done by the author.
    • link to the link to the PR for the User-facing documentation
  • User facing Documentation
    • update any relevant documentation in gitbook by submitting a gitbook PR, and including the PR link here
    • ensure that the message of the final single commit is descriptive and prefixed with either feat: or fix: , others might be used in rare occasions as well, if there is no need to document the changes in the release notes. The changes or fixes should be described in detail in the commit message for the changelog & release notes.
  • Testing
    • Changes, removals and additions to functionality must be covered by acceptance / integration tests or smoke tests - either already existing ones, or new ones, created by the author of the PR.

Pull Request Review

All pull requests must undergo a thorough review process before being merged.
The review process of the code PR should include code review, testing, and any necessary feedback or revisions.
Pull request reviews of functionality developed in other teams only review the given documentation and test reports.

Manual testing will not be performed by the reviewing team, and is the responsibility of the author of the PR.

For Node projects: It’s important to make sure changes in package.json are also affecting package-lock.json correctly.

If a dependency is not necessary, don’t add it.

When adding a new package as a dependency, make sure that the change is absolutely necessary. We would like to refrain from adding new dependencies when possible.
Documentation PRs in gitbook are reviewed by Snyk's content team. They will also advise on the best phrasing and structuring if needed.

Pull Request Approval

Once a pull request has been reviewed and all necessary revisions have been made, it is approved for merging into
the main codebase. The merging of the code PR is performed by the code owners, the merging of the documentation PR
by our content writers.

What does this PR do?

Reduce run time for prepare-build by 10-15 seconds, this job has a p95 of 4m 4s over the last 30 days. What makes this change worthwhile is that this job is the bottleneck before we fan out to our platform specific processes.

Screenshot 2024-03-21 at 11 02 22

  • Introduces dependency caching around npm for the prepare-build
  • Adopt a few flags for npm ci aimed at improving performance of command
    • --no-audit: Skipping the audit check can save time during the installation process because npm won't spend resources analyzing packages for security vulnerabilities. We already have leading security tool snyk integrated elsewhere in our build pipeline ;)
    • --no-progress: Disabling the progress bar can slightly improve performance by reducing the overhead of updating and rendering progress information in the terminal. This improvement may be more noticeable in automated or CI/CD (Continuous Integration/Continuous Deployment) environments where visual feedback is less critical.
    • --cache .npm: Specifying a cache directory (--cache) allows us to reliably cache this with CircleCI
    • --prefer-offline: This option can also boost performance, particularly in scenarios where network connectivity is unreliable or slow. By preferring offline packages, npm first looks for cached packages in the local cache directory (./npm) or any previously downloaded packages, reducing the need for network requests during installation.

@thisislawatts thisislawatts force-pushed the chore/ci-introduce-npm-caching branch from a677efd to 4a0a0b3 Compare March 12, 2024 14:52
@thisislawatts thisislawatts force-pushed the chore/ci-introduce-npm-caching branch from 4a0a0b3 to 5c7a44f Compare March 21, 2024 09:51
@thisislawatts thisislawatts marked this pull request as ready for review March 21, 2024 10:03
@thisislawatts thisislawatts requested a review from a team as a code owner March 21, 2024 10:03
@thisislawatts thisislawatts force-pushed the chore/ci-introduce-npm-caching branch from 5c7a44f to 1abbd95 Compare March 26, 2024 11:27
@thisislawatts thisislawatts enabled auto-merge (squash) March 26, 2024 11:47
@thisislawatts thisislawatts merged commit a4b4dbb into main Mar 26, 2024
11 checks passed
@thisislawatts thisislawatts deleted the chore/ci-introduce-npm-caching branch March 26, 2024 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants