chore(ci): introduce caching around npm install step #5110
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Submission
Please check the boxes once done.
The pull request must:
feat:
orfix:
, others might be used in rare occasions as well, if there is no need to document the changes in the release notes. The changes or fixes should be described in detail in the commit message for the changelog & release notes.Pull Request Review
All pull requests must undergo a thorough review process before being merged.
The review process of the code PR should include code review, testing, and any necessary feedback or revisions.
Pull request reviews of functionality developed in other teams only review the given documentation and test reports.
Manual testing will not be performed by the reviewing team, and is the responsibility of the author of the PR.
For Node projects: It’s important to make sure changes in
package.json
are also affectingpackage-lock.json
correctly.If a dependency is not necessary, don’t add it.
When adding a new package as a dependency, make sure that the change is absolutely necessary. We would like to refrain from adding new dependencies when possible.
Documentation PRs in gitbook are reviewed by Snyk's content team. They will also advise on the best phrasing and structuring if needed.
Pull Request Approval
Once a pull request has been reviewed and all necessary revisions have been made, it is approved for merging into
the main codebase. The merging of the code PR is performed by the code owners, the merging of the documentation PR
by our content writers.
What does this PR do?
Reduce run time for
prepare-build
by 10-15 seconds, this job has a p95 of 4m 4s over the last 30 days. What makes this change worthwhile is that this job is the bottleneck before we fan out to our platform specific processes.prepare-build
npm ci
aimed at improving performance of command--no-audit
: Skipping the audit check can save time during the installation process because npm won't spend resources analyzing packages for security vulnerabilities. We already have leading security toolsnyk
integrated elsewhere in our build pipeline ;)--no-progress
: Disabling the progress bar can slightly improve performance by reducing the overhead of updating and rendering progress information in the terminal. This improvement may be more noticeable in automated or CI/CD (Continuous Integration/Continuous Deployment) environments where visual feedback is less critical.--cache .npm
: Specifying a cache directory (--cache) allows us to reliably cache this with CircleCI--prefer-offline
: This option can also boost performance, particularly in scenarios where network connectivity is unreliable or slow. By preferring offline packages, npm first looks for cached packages in the local cache directory (./npm) or any previously downloaded packages, reducing the need for network requests during installation.