test: unexpected-error test expects non-colored output #5275
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thisislawatts
force-pushed
the
unexpected-error-FORCE_COLOR
branch
from
3f75051
to
eb534db
Compare
thisislawatts
force-pushed
the
unexpected-error-FORCE_COLOR
branch
from
eb534db
to
a7b5d03
Compare
The assertions in unexpected-error.spec.ts expect the output being tested to not contain ANSI color codes. To ensure that is always the case, set FORCE_COLOR="0" so node doesn't output colors. Without this change, this test will pass or fail depending upon the terminal being used to run the tests. With this change, the test runs consistently.
thisislawatts
force-pushed
the
unexpected-error-FORCE_COLOR
branch
from
a7b5d03
to
dcfbeec
Compare
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rebase for #4813, but otherwise no changes made.