Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: [OSM-1028] bump dotnet plugin to better handle nuget lockfiles #5309

Closed
wants to merge 2 commits into from

Conversation

JCheung2004
Copy link
Member

@JCheung2004 JCheung2004 commented Jun 12, 2024

Pull Request Submission

Please check the boxes once done.

The pull request must:

  • Reviewer Documentation
    • follow CONTRIBUTING rules
    • be accompanied by a detailed description of the changes
    • contain a risk assessment of the change (Low | Medium | High) with regards to breaking existing functionality. A change e.g. of an underlying language plugin can completely break the functionality for that language, but appearing as only a version change in the dependencies.
    • highlight breaking API if applicable
    • contain a link to the automatic tests that cover the updated functionality.
    • contain testing instructions in case that the reviewer wants to manual verify as well, to add to the manual testing done by the author.
    • link to the link to the PR for the User-facing documentation
  • User facing Documentation
    • update any relevant documentation in gitbook by submitting a gitbook PR, and including the PR link here
    • ensure that the message of the final single commit is descriptive and prefixed with either feat: or fix: , others might be used in rare occasions as well, if there is no need to document the changes in the release notes. The changes or fixes should be described in detail in the commit message for the changelog & release notes.
  • Testing
    • Changes, removals and additions to functionality must be covered by acceptance / integration tests or smoke tests - either already existing ones, or new ones, created by the author of the PR.

Pull Request Review

All pull requests must undergo a thorough review process before being merged.
The review process of the code PR should include code review, testing, and any necessary feedback or revisions.
Pull request reviews of functionality developed in other teams only review the given documentation and test reports.

Manual testing will not be performed by the reviewing team, and is the responsibility of the author of the PR.

For Node projects: It’s important to make sure changes in package.json are also affecting package-lock.json correctly.

If a dependency is not necessary, don’t add it.

When adding a new package as a dependency, make sure that the change is absolutely necessary. We would like to refrain from adding new dependencies when possible.
Documentation PRs in gitbook are reviewed by Snyk's content team. They will also advise on the best phrasing and structuring if needed.

Pull Request Approval

Once a pull request has been reviewed and all necessary revisions have been made, it is approved for merging into
the main codebase. The merging of the code PR is performed by the code owners, the merging of the documentation PR
by our content writers.

What does this PR do?

Bumps the snyk-nuget-plugin to bring the CLI up to date to allow for improved handling of Nuget projects that contain lockfiles.

Risk Assessment: Low

Should only affect CLI flows where users are scanning .NET projects with a lockfile.

Where should the reviewer start?

The PR here to see what functionality has been added

How should this be manually tested?

npm link to the newest version of snyk-nuget-plugin and run that against the fixture added in this repo.

Any background context you want to provide?

Adding to improve our .NET support

What are the relevant tickets?

OSM-1028

Screenshots

N/A

Additional questions

N/A

Copy link
Contributor

github-actions bot commented Jun 12, 2024

Warnings
⚠️

"feat: bump dotnet plugin to better publish with lockfiles when available" is too long. Keep the first line of your commit message under 72 characters.

Generated by 🚫 dangerJS against 468ca3a

@JCheung2004 JCheung2004 force-pushed the OSM-1028/adding-arguement-to-dotnet-publish branch from 8572b4a to 6c2cecc Compare June 12, 2024 20:22
@JCheung2004 JCheung2004 changed the title feat: bump dotnet plugin to better publish with lockfiles when available feat: bump dotnet plugin to better handle lockfiles when available Jun 12, 2024
@JCheung2004 JCheung2004 changed the title feat: bump dotnet plugin to better handle lockfiles when available feat: [OSM-1028] bump dotnet plugin to better handle nuget lockfiles Jun 12, 2024
@JCheung2004 JCheung2004 marked this pull request as ready for review June 12, 2024 20:37
@JCheung2004 JCheung2004 requested a review from a team as a code owner June 12, 2024 20:37
@JCheung2004 JCheung2004 force-pushed the OSM-1028/adding-arguement-to-dotnet-publish branch from 3e42a05 to 2206b30 Compare June 28, 2024 11:29
@JCheung2004 JCheung2004 force-pushed the OSM-1028/adding-arguement-to-dotnet-publish branch 2 times, most recently from 03eb35c to dec7ff8 Compare June 28, 2024 16:18
@JCheung2004 JCheung2004 force-pushed the OSM-1028/adding-arguement-to-dotnet-publish branch 2 times, most recently from 2206b30 to cc8de79 Compare June 28, 2024 16:30
@JCheung2004 JCheung2004 force-pushed the OSM-1028/adding-arguement-to-dotnet-publish branch from 7169796 to 5a95a74 Compare June 28, 2024 17:15
@JCheung2004
Copy link
Member Author

Will be closing this PR as this PR will include this change and is already merged

@JCheung2004 JCheung2004 closed this Jul 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants