fix(test, monitor): support for pipenv with python 3.12 #5388
+39
−50
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Submission
Please check the boxes once done.
The pull request must:
feat:
orfix:
, others might be used in rare occasions as well, if there is no need to document the changes in the release notes. The changes or fixes should be described in detail in the commit message for the changelog & release notes.Pull Request Review
All pull requests must undergo a thorough review process before being merged.
The review process of the code PR should include code review, testing, and any necessary feedback or revisions.
Pull request reviews of functionality developed in other teams only review the given documentation and test reports.
Manual testing will not be performed by the reviewing team, and is the responsibility of the author of the PR.
For Node projects: It’s important to make sure changes in
package.json
are also affectingpackage-lock.json
correctly.If a dependency is not necessary, don’t add it.
When adding a new package as a dependency, make sure that the change is absolutely necessary. We would like to refrain from adding new dependencies when possible.
Documentation PRs in gitbook are reviewed by Snyk's content team. They will also advise on the best phrasing and structuring if needed.
Pull Request Approval
Once a pull request has been reviewed and all necessary revisions have been made, it is approved for merging into
the main codebase. The merging of the code PR is performed by the code owners, the merging of the documentation PR
by our content writers.
What does this PR do?
Fix support for pipenv projects with python 3.12, also removed setuptools installation for python 3.12 projects as it's not needed only in the context of setup.py: snyk/snyk-python-plugin#246
Where should the reviewer start?
Added acceptance test for pipenv project, there was none for this.
Already existing python acceptance tests cover the functionality for python.
How should this be manually tested?
For a pipenv project (acceptance workspace I added for example), with python 3.12 as current python version, run snyk test. It was previously throwing an error, now it succeeds.
Any background context you want to provide?
Do we want to have all the supported python versions installed on each OS for acceptance tests on the pipeline? Our snyk-python-plugin alread runs tests on all python versions, covering this.
What are the relevant tickets?
https://snyksec.atlassian.net/browse/T3S-84
Screenshots
Additional questions