Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(test, monitor): support for pipenv with python 3.12 #5388

Merged
merged 1 commit into from
Aug 8, 2024

Conversation

gemaxim
Copy link
Contributor

@gemaxim gemaxim commented Jul 31, 2024

Pull Request Submission

Please check the boxes once done.

The pull request must:

  • Reviewer Documentation
    • follow CONTRIBUTING rules
    • be accompanied by a detailed description of the changes
    • contain a risk assessment of the change (Low | Medium | High) with regards to breaking existing functionality. A change e.g. of an underlying language plugin can completely break the functionality for that language, but appearing as only a version change in the dependencies.
    • highlight breaking API if applicable
    • contain a link to the automatic tests that cover the updated functionality.
    • contain testing instructions in case that the reviewer wants to manual verify as well, to add to the manual testing done by the author.
    • link to the link to the PR for the User-facing documentation
  • User facing Documentation
    • update any relevant documentation in gitbook by submitting a gitbook PR, and including the PR link here
    • ensure that the message of the final single commit is descriptive and prefixed with either feat: or fix: , others might be used in rare occasions as well, if there is no need to document the changes in the release notes. The changes or fixes should be described in detail in the commit message for the changelog & release notes.
  • Testing
    • Changes, removals and additions to functionality must be covered by acceptance / integration tests or smoke tests - either already existing ones, or new ones, created by the author of the PR.

Pull Request Review

All pull requests must undergo a thorough review process before being merged.
The review process of the code PR should include code review, testing, and any necessary feedback or revisions.
Pull request reviews of functionality developed in other teams only review the given documentation and test reports.

Manual testing will not be performed by the reviewing team, and is the responsibility of the author of the PR.

For Node projects: It’s important to make sure changes in package.json are also affecting package-lock.json correctly.

If a dependency is not necessary, don’t add it.

When adding a new package as a dependency, make sure that the change is absolutely necessary. We would like to refrain from adding new dependencies when possible.
Documentation PRs in gitbook are reviewed by Snyk's content team. They will also advise on the best phrasing and structuring if needed.

Pull Request Approval

Once a pull request has been reviewed and all necessary revisions have been made, it is approved for merging into
the main codebase. The merging of the code PR is performed by the code owners, the merging of the documentation PR
by our content writers.

What does this PR do?

Fix support for pipenv projects with python 3.12, also removed setuptools installation for python 3.12 projects as it's not needed only in the context of setup.py: snyk/snyk-python-plugin#246

Where should the reviewer start?

Added acceptance test for pipenv project, there was none for this.
Already existing python acceptance tests cover the functionality for python.

How should this be manually tested?

For a pipenv project (acceptance workspace I added for example), with python 3.12 as current python version, run snyk test. It was previously throwing an error, now it succeeds.

Any background context you want to provide?

Do we want to have all the supported python versions installed on each OS for acceptance tests on the pipeline? Our snyk-python-plugin alread runs tests on all python versions, covering this.

What are the relevant tickets?

https://snyksec.atlassian.net/browse/T3S-84

Screenshots

Additional questions

@gemaxim gemaxim self-assigned this Jul 31, 2024
@gemaxim gemaxim force-pushed the fix/pipenv-python-3.12-support branch 12 times, most recently from 82c5822 to d077587 Compare August 6, 2024 08:45
@gemaxim gemaxim marked this pull request as ready for review August 6, 2024 17:12
@gemaxim gemaxim requested a review from a team as a code owner August 6, 2024 17:12
@gemaxim gemaxim force-pushed the fix/pipenv-python-3.12-support branch 2 times, most recently from 78176ee to 514251c Compare August 6, 2024 17:14
@gemaxim gemaxim changed the title fix: support for pipenv with python 3.12 fix(test, monitor): support for pipenv with python 3.12 Aug 6, 2024
@gemaxim gemaxim force-pushed the fix/pipenv-python-3.12-support branch from 514251c to 09df3bc Compare August 8, 2024 18:03
@gemaxim gemaxim merged commit 60c2939 into main Aug 8, 2024
11 checks passed
@gemaxim gemaxim deleted the fix/pipenv-python-3.12-support branch August 8, 2024 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants