refactor: simplify middleware code

following code review feedback. pkg/middlewares/aws_route_table_expander.go
snyk · Apr 7, 2021 · 0e001f2 · 0e001f2
1 parent c671651
commit 0e001f2
Showing 1 changed file with 2 additions and 8 deletions.
diff --git a/pkg/middlewares/aws_route_table_expander.go b/pkg/middlewares/aws_route_table_expander.go
@@ -172,15 +172,9 @@ func (m *AwsRouteTableExpander) handleDefaultTable(table *aws.AwsDefaultRouteTab
 
 func (m *AwsRouteTableExpander) routeExists(routeId string, resourcesFromState []resource.Resource) bool {
 	for _, res := range resourcesFromState {
-		if res.TerraformType() != aws.AwsRouteResourceType {
-			continue
+		if res.TerraformType() == aws.AwsRouteResourceType && res.TerraformId() == routeId {
+			return true
 		}
-
-		if res.TerraformId() != routeId {
-			continue
-		}
-
-		return true
 	}
 
 	return false