Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove useless exports in VPC supplier #104

Merged
merged 2 commits into from
Jan 11, 2021
Merged

Conversation

eliecharra
Copy link
Contributor

Q A
πŸ› Bug fix? no
πŸš€ New feature? no
⚠ Deprecations? no
❌ BC Break no
πŸ”— Related issues #...
❓ Documentation no

@eliecharra eliecharra added the kind/maintenance Refactoring or changes to the workspace label Jan 11, 2021
@eliecharra eliecharra requested a review from a team as a code owner January 11, 2021 17:20
@codecov
Copy link

codecov bot commented Jan 11, 2021

Codecov Report

Merging #104 (7662214) into main (1bae5fa) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #104   +/-   ##
=======================================
  Coverage   67.09%   67.09%           
=======================================
  Files         153      153           
  Lines        3495     3495           
=======================================
  Hits         2345     2345           
  Misses        890      890           
  Partials      260      260           
Impacted Files Coverage Ξ”
pkg/remote/aws/vpc_supplier.go 61.11% <100.00%> (ΓΈ)

@eliecharra eliecharra merged commit 2a194c2 into main Jan 11, 2021
@eliecharra eliecharra deleted the fix_useless_exported_fields branch January 11, 2021 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/maintenance Refactoring or changes to the workspace
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants