Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add aws_nat_gateway #134

Merged
merged 2 commits into from
Jan 21, 2021
Merged

Add aws_nat_gateway #134

merged 2 commits into from
Jan 21, 2021

Conversation

eliecharra
Copy link
Contributor

Q A
πŸ› Bug fix? no
πŸš€ New feature? yes
⚠ Deprecations? no
❌ BC Break no
πŸ”— Related issues #97
❓ Documentation yes

Description

⚠️ Pay attention to the middleware

@eliecharra eliecharra added the kind/enhancement New feature or improvement label Jan 20, 2021
@eliecharra eliecharra requested a review from a team January 20, 2021 16:32
@codecov
Copy link

codecov bot commented Jan 20, 2021 •
edited
Loading

Codecov Report

Merging #134 (4543525) into main (b83c622) will decrease coverage by 0.00%.
The diff coverage is 67.07%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #134      +/-   ##
==========================================
- Coverage   67.51%   67.51%   -0.01%     
==========================================
  Files         175      179       +4     
  Lines        3987     4069      +82     
==========================================
+ Hits         2692     2747      +55     
- Misses       1000     1020      +20     
- Partials      295      302       +7
Impacted Files Coverage Ξ”
pkg/driftctl.go 0.00% <0.00%> (ΓΈ)
pkg/remote/aws/init.go 0.00% <0.00%> (ΓΈ)
...ource/aws/deserializer/nat_gateway_deserializer.go 53.33% <53.33%> (ΓΈ)
pkg/remote/aws/nat_gateway_supplier.go 53.84% <53.84%> (ΓΈ)
pkg/iac/deserializers.go 100.00% <100.00%> (ΓΈ)
pkg/middlewares/aws_nat_gateway_eip_assoc.go 100.00% <100.00%> (ΓΈ)
pkg/resource/aws/aws_nat_gateway.go 100.00% <100.00%> (ΓΈ)
... and 1 more

wbeuil
wbeuil approved these changes Jan 21, 2021
View reviewed changes
Copy link
Contributor

@wbeuil wbeuil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@eliecharra eliecharra merged commit a6559dc into main Jan 21, 2021
@eliecharra eliecharra deleted the add_aws_nat_gateway branch January 21, 2021 14:31
@eliecharra eliecharra linked an issue Jan 21, 2021 that may be closed by this pull request
Support aws_nat_gateway #97
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wbeuil wbeuil wbeuil approved these changes

Assignees
No one assigned
Labels
kind/enhancement New feature or improvement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support aws_nat_gateway
2 participants
@eliecharra @wbeuil