Update retry policy for GCP acc tests #1345
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Increase the retry duration limit from 10 to 15 minutes.
sundowndev
requested review from
almog27,
eliecharra and
craigfurman
and removed request for
a team and
almog27
Increase the retry duration limit from 10 to 15 minutes.
sundowndev
force-pushed
the
fix/acc_google_bigquery_table_test
branch
from
c35151e
to
4a15b76
Compare
sundowndev
changed the title
Codecov Report
@@ Coverage Diff @@
## main #1345 +/- ##
==========================================
+ Coverage 73.17% 82.02% +8.85%
==========================================
Files 482 410 -72
Lines 18092 14948 -3144
==========================================
- Hits 13238 12261 -977
+ Misses 4535 2387 -2148
+ Partials 319 300 -19
|
craigfurman
approved these changes
Feb 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Those particular tests seems to have more regression than others. This PR increases the retry duration from 10 to 15 minutes so it will retry one more time after sleeping for 8 min.
Also added a field
retry_durationto debug logs so we can figure out the elapsed time for this test to pass/fail in the future.References